Modify healthcheck to get port from config.json instead of hard-coding to 5150 - #114

Review: Healthcheck Dynamic Port

Nice improvement — the script is clean and well-structured. One functional concern and a couple of minor suggestions:

🟡 Medium: Environment variable override not detected

The config loader in server/config/Config.ts applies POOL_WEB_SERVERS_HTTP_PORT (and similar env vars) at runtime in-memory — they're never written back to config.json on disk. If a user configures their port solely via environment variable (as documented in docker-compose.yml comments), the healthcheck will still read 5150 from the static file and fail.

Suggested fix in docker/healthcheck.js — after reading the config file, add an env var fallback:

// Match the config loader's env var behavior
const envPort = process.env.POOL_WEB_SERVERS_HTTP_PORT;
if (envPort) {
    const parsed = parseInt(envPort, 10);
    if (!isNaN(parsed)) port = parsed;
}

💡 Minor: curl is now unused

The runtime stage still installs curl (apk add --no-cache curl) which was only needed for the old healthcheck. Removing it saves ~2MB from the image.

💡 Minor: COPY placement

The COPY docker/healthcheck.js /usr/local/bin/healthcheck.js line is placed after USER node. While this works (COPY runs as root at build time regardless), it's more conventional to group it with the other COPY statements above the USER directive.

Otherwise the implementation looks solid — proper timeout handling, clean status code check, graceful config fallback with optional chaining.